cache more unit tests: loads of small changes - #111
Merged
Conversation
rahulbot
marked this pull request as ready for review
August 24, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was having tons of problems from here in Berlin with loading webpages for these unit tests. However, only a very small set of these actually need a live internet connection; most are about operating on HTML. So I redid the cache approach here to use cached HTML as much as possible and leave only the handful of tests that work on redirects and such without any cached fixture. These tests all pass much more quickly.
Part of this is also motivated by adding automated testing on more python versions, so more reliable, repeatable, and faster running of all our unit tests is very desirable.